pipelines icon indicating copy to clipboard operation
pipelines copied to clipboard

feat(Backend + SDK): Update kfp backend and kubernetes sdk to support ImagePullPolicy

Open revit13 opened this issue 1 year ago • 7 comments
trafficstars

Description of your changes: Part of Part of https://github.com/kubeflow/pipelines/issues/9714 and https://github.com/kubeflow/pipelines/issues/9980

Update kfp backend and kubernetes sdk to support image pull policy. To be rebased and update go.mod after #10416

Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

revit13 avatar Jan 21 '24 09:01 revit13

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 21 '24 09:01 google-cla[bot]

Hi @revit13. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jan 21 '24 09:01 google-oss-prow[bot]

rebase and update go.mod after #10416

Tomcli avatar Jan 22 '24 16:01 Tomcli

/ok-to-test

Tomcli avatar Feb 07 '24 18:02 Tomcli

/assign @chensun /assign @connor-mccarthy

zijianjoy avatar Feb 08 '24 23:02 zijianjoy

/assign @chensun

Tomcli avatar Feb 26 '24 17:02 Tomcli

@revit13 Can you please rebase and resolve the conflicts?

chensun avatar Mar 05 '24 18:03 chensun

@revit13 Can you please rebase and resolve the conflicts?

@chensun Done, Thanks

revit13 avatar Mar 05 '24 21:03 revit13

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Mar 05 '24 21:03 google-oss-prow[bot]

@revit13: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 09fbe3edcd9810093ae691dfb9066124db16bee2 link false /test kubeflow-pipelines-samples-v2
kfp-kubernetes-execution-tests 09fbe3edcd9810093ae691dfb9066124db16bee2 link false /test kfp-kubernetes-execution-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Mar 05 '24 21:03 google-oss-prow[bot]