mpi-operator icon indicating copy to clipboard operation
mpi-operator copied to clipboard

OpenMPI 4.1.5

Open bdevcich opened this issue 1 year ago • 11 comments

Any plans to update to the latest stable version of OpenMPI?

bdevcich avatar Aug 18 '23 15:08 bdevcich

It should just work. Feel free to send a PR.

alculquicondor avatar Aug 18 '23 15:08 alculquicondor

IIRC, we don't specify the OpenMPI version. So just rebuilding the image might be enough.

https://github.com/kubeflow/mpi-operator/blob/6bce22d1ab3a42e7ea52ef573afbc662a49c18a5/build/base/openmpi.Dockerfile#L6

tenzen-y avatar Aug 18 '23 15:08 tenzen-y

It appears that 4.1.0 is the latest that is going to be provided with bullseye: https://packages.debian.org/bullseye/openmpi-bin. I didn't see any updated packages in the updates.

It looks like bookworm has 4.1.4: https://packages.debian.org/bookworm/openmpi-bin

Any concerns with building openmpi from source?

bdevcich avatar Aug 18 '23 15:08 bdevcich

I see.

Any concerns with building openmpi from source?

I want to avoid building the OpenMPI to avoid increasing maintenance costs.

It looks like bookworm has 4.1.4: https://packages.debian.org/bookworm/openmpi-bin

Actually, we already have a PR to update the Debian version, although there are unresolved issues: https://github.com/kubeflow/mpi-operator/pull/573

Can you try to update the Debian version instead of building OpenMPI?

WDYT? @alculquicondor @terrytangyuan

tenzen-y avatar Aug 18 '23 15:08 tenzen-y

Yes, prefer to update the debian version.

alculquicondor avatar Aug 18 '23 16:08 alculquicondor

Agreed. We should not build it from source

terrytangyuan avatar Aug 18 '23 18:08 terrytangyuan

Thanks.

Makes sense. It adds some complexity. I think 4.1.4 (that comes with bookworm) will be fine as it contains the fix that we're interested in.

So the path forward is to get traction on #573 ?

bdevcich avatar Aug 18 '23 18:08 bdevcich

Thanks.

Makes sense. It adds some complexity. I think 4.1.4 (that comes with bookworm) will be fine as it contains the fix that we're interested in.

So the path forward is to get traction on #573 ?

I think you can open the new PR :)

tenzen-y avatar Aug 18 '23 18:08 tenzen-y

In any case, you should be able to run any version of OpenMPI with the operator. You can build your containers against bookworm (or any other distro).

alculquicondor avatar Aug 18 '23 18:08 alculquicondor

@bdevcich @tenzen-y is there a reason why we do not make the install from source?

abeltre1 avatar Nov 06 '23 23:11 abeltre1

@bdevcich @tenzen-y is there a reason why we do not make the install from source?

As I mentioned the above (https://github.com/kubeflow/mpi-operator/issues/588#issuecomment-1684121799), we should avoid increasing maintenance costs.

tenzen-y avatar Nov 14 '23 17:11 tenzen-y