model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard
verified publisher icon kubeflow

Fix Toolbar Alignment in Model Registry UI

Open chandanasirigineedi opened this issue 8 months ago • 7 comments

Description

Corrected alignment issues on the Model Registry page #931

How Has This Been Tested?

Locally Tested UI with Mock Backend

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [ X] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ X] The developer has manually tested the changes and verified that the changes work.
  • [ ] Code changes follow the kubeflow contribution guidelines.
  • [ X] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • [ ] The developer has added tests or explained why testing cannot be added.
  • [ X] Included any necessary screenshots or gifs if it was a UI change.
  • [ X] Verify that UI/UX changes conform the UX guidelines for Kubeflow. image

chandanasirigineedi avatar Apr 16 '25 21:04 chandanasirigineedi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Apr 16 '25 21:04 google-oss-prow[bot]

cc @Al-Pragliola @andreyvelich Can you guys take a look at it, please?

chandanasirigineedi avatar Apr 17 '25 18:04 chandanasirigineedi

/assign

jenny-s51 avatar Apr 17 '25 18:04 jenny-s51

Thanks for your PR @chandanasirigineedi 🎉 I will pull it down and take a look!

jenny-s51 avatar Apr 17 '25 18:04 jenny-s51

@chandanasirigineedi I PR-ed your PR with some additional refinements here. Can you sync your branch with the latest changes on main before you approve/merge? Thanks!

jenny-s51 avatar Apr 18 '25 17:04 jenny-s51

@jenny-s51 Thank you I’ll update my branch and review again shortly.

chandanasirigineedi avatar Apr 21 '25 17:04 chandanasirigineedi

/assign @jenny-s51

ederign avatar Apr 21 '25 20:04 ederign

Hi @tarilabs, this PR has been superseded by the work in #1140. Could you please help close this one out when you have a moment?

Thank you @chandanasirigineedi we've integrated the progress and efforts from this PR into the one linked above. Your work is greatly appreciated, and we welcome your contributions! 🚀

jenny-s51 avatar May 20 '25 21:05 jenny-s51

closing per https://github.com/kubeflow/model-registry/pull/989#issuecomment-2895875862

thank you @chandanasirigineedi and @jenny-s51

tarilabs avatar May 21 '25 09:05 tarilabs