model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard

[Proposal] Official Docker Github Actions for CI workflows

Open mahdikhashan opened this issue 11 months ago • 3 comments

Is your feature request related to a problem? Please describe. while i was working on image publishing on the ghcr registry, I noticed that custom commands are being used for building, tagging and publishing with combination of bash and makefile. this part of code is verbose and there are possible abstraction.

Describe the solution you'd like use official docker action and custom template based actions for publishing images

Describe alternatives you've considered

  • on other kubeflow project like Katib and trainer, the same approach is being used
  • there they dont have the requirement to publish images to local registries

Additional context as was discussed on 13.3 community meeting, the previous decision to implement this solution has been duo to requirement to publish image on local registry.

cc: @tarilabs

mahdikhashan avatar Mar 18 '25 09:03 mahdikhashan

I opened this issue to document our discussion yesterday, thank you for this suggestion @tarilabs.

mahdikhashan avatar Mar 18 '25 09:03 mahdikhashan

Thank you @mahdikhashan for raising this. As discussed in the KF MR biweekly meeting, https://youtu.be/tWF_Rv1pUtU?si=TgaPXcXJ1QNmEkDJ&t=2639 the reason we decided not to leverage the bespoke GitHub action from Docker is to keep our CI agnostic of a single vendor/solution, and leverage the same tools a Developer would use on a local machine to publish a local build to their own registry/internal registry.

Specifically, here:

https://github.com/kubeflow/model-registry/blob/44be67252a6bd948edacd0dfd33b6583a6c80450/scripts/build_deploy.sh#L48-L75

and most importantly from makefile here:

https://github.com/kubeflow/model-registry/blob/44be67252a6bd948edacd0dfd33b6583a6c80450/Makefile#L263-L298

This way, we can have the definition in a single place, and not have a script+makefile only for local development and a separate flow from GitHub Action.

We're curious to hear if any Working Groups have found a solution to this paragraph above ☝ , otherwise I will eventually close this report. Hope this summarizes, thanks!

tarilabs avatar Mar 19 '25 09:03 tarilabs

thank you, this totally makes sense.

mahdikhashan avatar Mar 19 '25 09:03 mahdikhashan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 18 '25 04:06 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jul 08 '25 04:07 github-actions[bot]