model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard

Misleading reference to DELETE operations in OpenAPI schema

Open dmartinol opened this issue 1 year ago • 2 comments

Describe the bug The OpenAPI schema includes the DELETE operation for some of the managed paths, but delete services are not really implemented.

To Reproduce See an example of misleading description here.

Note that there is no delete operation under these paths.

Also, if we try to curl -X DELETE, it returns HTTP/1.1 405 Method Not Allowed

Expected behavior Either implement the described operations or fix the documentation.

dmartinol avatar Apr 12 '24 15:04 dmartinol

Thank you for reporting this @dmartinol ; as explained, Google ML-Metadata (which Model Registry is based on), does not support deletion semantic. We get support only of status change. As you correctly say, the description should be reflected.

The OpenAPI schema includes the DELETE operation for some of the managed paths, but delete services are not really implemented.

There is no entry in OpenAPI for delete: verb in https://github.com/kubeflow/model-registry/blob/main/api/openapi/model-registry.yaml

This is to be reflected basically in all textual documentation.

tarilabs avatar Apr 12 '24 16:04 tarilabs

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 15 '24 04:07 github-actions[bot]