model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard

Apply MUI theming to "Versions" and "Details" Screens

Open jenny-s51 opened this issue 4 months ago • 1 comments

Description

Applies MUI theming to "Versions" and "Details" Screens

Model Versions List View - Before: Screenshot 2024-10-10 at 2 03 19 PM

Model Versions List View - After: Screenshot 2024-10-10 at 2 02 56 PM

Model Details Description Input - Before: Screenshot 2024-10-10 at 2 03 32 PM

Model Details Description Input - After: Screenshot 2024-10-10 at 2 02 07 PM

Model Details Properties Table - Before: Screenshot 2024-10-10 at 2 03 48 PM

Model Details Properties Table - After: Screenshot 2024-10-10 at 2 04 14 PM

How Has This Been Tested?

What's been changed:

  1. Model Versions List View

    • "Register Version" Button - applied MUI hover color
    • Page container - updated to apply MUI border radius and drop shadow
    • Tabs - Fixed padding bug to center text within tab correctly
    • Search input - replaced existing search filter component with new FormFieldset component to apply MUI theming
  2. Model Details View

    • Action buttons (i.e. "Edit", "Add Property") - applied MUI link styling to darken underline of link button when hovered
    • "Description" field - replaced with new FormFieldset component to apply MUI theming
    • Properties table - replaced Key / Value inputs with FormFieldset components to apply MUI theming
    • Action buttons: Updated border radius on hover to apply MUI theming

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [x] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • [x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [x] The developer has manually tested the changes and verified that the changes work.
  • [x] Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • [x] The developer has added tests or explained why testing cannot be added.
  • [x] Included any necessary screenshots or gifs if it was a UI change.
  • [x] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

jenny-s51 avatar Oct 10 '24 18:10 jenny-s51