[tracker] next steps ModelRegistry Custom Storage Initializer
- [ ] Add image build directive in the model registry root Makefile (re-using csi Makefile)
- [ ] update KServe website, following this: https://github.com/kserve/website/pull/346
to show integration of CSI image here in KF/model-registry instead of the current placeholder of the example
image: abc/model-registry-storage-initializer:latest(should read eventually something likeimage: kubeflow/model-registry-storage-initializer:latest) - [ ] Set container image registry
- [ ] Add some testing focusing on the MR interaction using testcontainers (mocking the download itself)
Stretch goals:
- [ ] Use
kiota(or other openapi code-generators) to autogenerate the client, this will make the CSI less dependent on the internal model registry implementation (this will also make the CSI just tied to the openapi spec rather than MR version)- https://github.com/kubeflow/model-registry/issues/338
See previous work on this topic:
- https://github.com/kubeflow/model-registry/pull/25#issuecomment-1973008080
- https://github.com/kubeflow/model-registry/issues/24
If you-reading-this-issue start to work on any of these points, kindly notify by creating a relevant issue, assign it to yourself and reach out to confirm scope with the maintainers :)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
this is being worked with: https://github.com/kubeflow/model-registry/pull/154
Stretch goal being tracked by https://github.com/kubeflow/model-registry/issues/338
@tarilabs I think that all non-stretch goals (except for "update KServe website") can be considered as done/completed so I think you can tick the corresponding boxes in this PR's description
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.
/reopen
I believe all boxes are meant be ticked, to review.
@tarilabs: Reopened this issue.
In response to this:
/reopen
I believe all boxes are meant be ticked, to review.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
I believe all boxes are meant be ticked, to review.
@tarilabs I think the "Update KServe Website" can be ticked as well (this should have been addressed by your PR https://github.com/kserve/website/pull/414)
The only outstanding bullet point is "add a simple, short "tutorial" on kubeflow.org website ( follow-up with @Al-Pragliola )", but not sure whether this is kind of needed or not. Up to you guys.
I believe all boxes are meant be ticked, to review.
@tarilabs I think the "Update KServe Website" can be ticked as well (this should have been addressed by your PR kserve/website#414)
The only outstanding bullet point is "add a simple, short "tutorial" on kubeflow.org website ( follow-up with @Al-Pragliola )", but not sure whether this is kind of needed or not. Up to you guys.
We have added a section here: https://www.kubeflow.org/docs/components/model-registry/installation/#standalone-installation
and here: https://www.kubeflow.org/docs/components/model-registry/getting-started/#using-model-registry-custom-storage-initializer
is it enough?
I believe all boxes are meant be ticked, to review.
thank you @lampajr @Al-Pragliola for confirming all boxes can be ticket.
marking as Complete.