model-registry
model-registry copied to clipboard
fix: filterQuery AND condition not working correctly
Description
The bug was in the artifact filtering logic for model queries. When multiple artifact property conditions were combined with AND, each condition created its own independent EXISTS subquery, which incorrectly matched models where:
- One artifact matched condition A
- A different artifact matched condition B
How Has This Been Tested?
Added a regression test, tested locally
Merge criteria:
- All the commits have been signed-off (To pass the
DCOcheck)
- [ ] The commits have meaningful messages
- [ ] Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
- [ ] The developer has manually tested the changes and verified that the changes work.
- [ ] Code changes follow the kubeflow contribution guidelines.
- [ ] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pboyd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~OWNERS~~ [pboyd]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment