model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard

feat: make catalog model fields nullable in OpenAPI spec

Open pboyd opened this issue 3 months ago • 1 comments

Description

Add nullable: true to catalog model fields and make them required.

This allows the API output for a model to more closely match the catalog file.

How Has This Been Tested?

Unit and E2E tests

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [x] The commits have meaningful messages
  • [x] Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [x] The developer has manually tested the changes and verified that the changes work.
  • [x] Code changes follow the kubeflow contribution guidelines.

pboyd avatar Nov 06 '25 16:11 pboyd

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from pboyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Nov 06 '25 16:11 google-oss-prow[bot]

I'm closing this because the fix is worse than the problem it's trying to solve.

pboyd avatar Dec 05 '25 00:12 pboyd