model-registry icon indicating copy to clipboard operation
model-registry copied to clipboard
verified publisher icon kubeflow

manifests: align default to #1113

Open tarilabs opened this issue 9 months ago • 1 comments

Description

follow-up to

  • https://github.com/kubeflow/model-registry/pull/1113 as requested in
  • https://github.com/kubeflow/manifests/pull/3137#pullrequestreview-2853615708

for consistency of the defaults (considered without the kustomize)

How Has This Been Tested?

GHAs

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • [x] The commits have meaningful messages
  • [ ] Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • [ ] The developer has manually tested the changes and verified that the changes work.
  • [ ] Code changes follow the kubeflow contribution guidelines.
  • [ ] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • [ ] The developer has added tests or explained why testing cannot be added.
  • [ ] Included any necessary screenshots or gifs if it was a UI change.
  • [ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow.

tarilabs avatar May 20 '25 10:05 tarilabs

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 20 '25 12:05 google-oss-prow[bot]

@tarilabs if you want regular security updates, then newTag: 8.3 or 8.4 for mysql is probably better than the static 8.3.0. KFP uses mysql:8.4 i think

juliusvonkohout avatar May 21 '25 16:05 juliusvonkohout

@tarilabs if you want regular security updates, then newTag: 8.3 or 8.4 for mysql is probably better than the static 8.3.0. KFP uses mysql:8.4 i think

logged as https://github.com/kubeflow/model-registry/issues/1144 👍

tarilabs avatar May 21 '25 19:05 tarilabs