Enable shared library on model registry
Description
This pull request introduces the integration of the mod-arch-shared package into the frontend project, along with related updates to dependencies, configurations, and imports. The most significant changes include adding the new package to the project, updating the Webpack configuration to handle nested dependencies, and modifying existing imports to use types and utilities from the shared package.
Integration of mod-arch-shared:
-
Added
mod-arch-sharedpackage todependenciesinpackage.jsonandpackage-lock.json, along with its required sub-dependencies and peer dependencies. This includes updates to support@patternflycomponents and other utilities. ([[1]](diffhunk://#diff-e9119f8483da2f9443a14c1c85862a2c5350f147144eb10ba706f263364f2121R23),[[2]](diffhunk://#diff-e9119f8483da2f9443a14c1c85862a2c5350f147144eb10ba706f263364f2121R15691-R15865),[[3]](diffhunk://#diff-bf27a93e89deb1eed915b9898f9108451249207028faefea6eb2de1be2ab85a3R115)) -
Updated Webpack configuration in
webpack.dev.jsto resolve nested@patternflymodules withinmod-arch-shared. This ensures compatibility with the shared package's dependencies. ([clients/ui/frontend/config/webpack.dev.jsR93-R96](diffhunk://#diff-542105a935fa70199fddb1c45d63485c236025b66857f270a6a4000a4d1e450bR93-R96))
Refactor of imports:
-
Replaced imports of
NamespaceandUserSettingstypes from local paths with imports frommod-arch-sharedin mock files (mockNamespace.ts,mockUserSettings.ts). ([[1]](diffhunk://#diff-75747fa538646f508ff3fe6ba848553c209b1c4642547c900902ff16de4e5d94L1-R1),[[2]](diffhunk://#diff-ce95ed1bf1af72a9ee0c2f0625f43f0a287f728245a8a1e4e0edc35a0c8314dfL1-R1)) -
Removed the
mockBFFResponseutility and its related imports since its functionality is now covered bymod-arch-shared. Updated relevant test files to use the shared package's utilities. ([[1]](diffhunk://#diff-26ca6d81f266a9adf4db3242d6f183667c2b274c9d723284773530cd62b46667L1-L5),[[2]](diffhunk://#diff-3763c694969e56830cc07641b5813daa219e7992a4e2d0fc941445054cf1b5a3L2-R2))
Cleanup of package-lock.json:
- Removed
devflags from several dependencies inpackage-lock.json, potentially indicating a shift of these dependencies to production or peer scope. ([[1]](diffhunk://#diff-e9119f8483da2f9443a14c1c85862a2c5350f147144eb10ba706f263364f2121L3619),[[2]](diffhunk://#diff-e9119f8483da2f9443a14c1c85862a2c5350f147144eb10ba706f263364f2121L3659),[[3]](diffhunk://#diff-e9119f8483da2f9443a14c1c85862a2c5350f147144eb10ba706f263364f2121L8822), etc.)
How Has This Been Tested?
Testing the PR manually
Merge criteria:
- All the commits have been signed-off (To pass the
DCOcheck)
- [ ] The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
- [ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
- [ ] The developer has manually tested the changes and verified that the changes work.
- [ ] Code changes follow the kubeflow contribution guidelines.
- [ ] For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label
ok-to-testhas been added to the PR.
If you have UI changes
- [ ] The developer has added tests or explained why testing cannot be added.
- [ ] Included any necessary screenshots or gifs if it was a UI change.
- [ ] Verify that UI/UX changes conform the UX guidelines for Kubeflow.
@lucferbux I tested these change locally and with kind. Everything looked to be running the same as before
/lgtm
/lgtm
/approve
/approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christianvogt, ederign
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [ederign]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment