manifests icon indicating copy to clipboard operation
manifests copied to clipboard

Published 20 hours ago • verified publisher icon kubeflow

Update kubeflow/model-registry manifests from v0.2.0-alpha

Open rimolive opened this issue 10 months ago • 7 comments

Which issue is resolved by this Pull Request: Supersedes #2694

Description of your changes:

Checklist:

  • [x] Unit tests pass: Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

rimolive avatar Apr 30 '24 13:04 rimolive

We should update the model registry synchronization script as I did for Katib in https://github.com/kubeflow/manifests/pull/2698

juliusvonkohout avatar Apr 30 '24 16:04 juliusvonkohout

Thanks @rimolive, note that the manifests README and OWNERS files that have been added with https://github.com/kubeflow/model-registry/pull/69 were not included in v0.2.0-alpha tag yet (as the PR has been merged yesterday).

As temporary solution, if really needed, we could add them manually as part of this PR. Wdyt?

lampajr avatar May 01 '24 09:05 lampajr

@lampajr Done

rimolive avatar May 03 '24 10:05 rimolive

/hold

Found an issue in the sync script.

rimolive avatar May 03 '24 16:05 rimolive

/unhold

rimolive avatar May 03 '24 16:05 rimolive

cc @juliusvonkohout

rimolive avatar May 04 '24 17:05 rimolive

networkpolicies etc. in follow up PRs

/lgtm /approve

juliusvonkohout avatar May 06 '24 13:05 juliusvonkohout

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [juliusvonkohout]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 06 '24 13:05 google-oss-prow[bot]