manifests icon indicating copy to clipboard operation
manifests copied to clipboard

Deprecate optional Knative Eventing components from common manifests

Open rawc0der opened this issue 1 year ago • 4 comments

Description: There are certain components which get deployed alongside all the required core Kubeflow stack. One example is the knative-eventing which is installed together with the KNative stack of services.

Suggestion: If this component is not required for Kubeflow inner workings, then my suggestion is to deprecate it from the /common folder. This install creates a lot of unnecessary deployments and resources on the cluster (which rarely get used for critical functionality).

Deprecation Note: In order to keep the integration and still allow users to continue installing it if needed, it can be added as separate integration to /contrib folder. If this introduce inconsistent conventions, then it could simply be commented out from the installation kustomization file such that it is not considered as required.

Any thoughts?

rawc0der avatar Apr 18 '24 15:04 rawc0der

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

/lifecycle frozen

juliusvonkohout avatar Jun 25 '24 10:06 juliusvonkohout

@juliusvonkohout for this, Do I need to move knative folder to contrib folder?

hansinikarunarathne avatar Jul 04 '24 05:07 hansinikarunarathne

It introduces inconsistent conventions, so it should simply be commented out from the installation kustomization file such that it is not considered as required.

juliusvonkohout avatar Jul 04 '24 15:07 juliusvonkohout

Solved in https://github.com/kubeflow/manifests/pull/2788

juliusvonkohout avatar Aug 12 '24 10:08 juliusvonkohout