manifests icon indicating copy to clipboard operation
manifests copied to clipboard

Update to Seldon 1.18.x and the corresponding owners file

Open juliusvonkohout opened this issue 10 months ago • 3 comments

We want to support Kubernetes 1.27 -1.29 in Kubeflow 1.9 and should update to Seldon 1.18+

https://docs.seldon.io/projects/seldon-core/en/latest/reference/upgrading.html

and there is discussion in https://github.com/kubeflow/manifests/pull/2532#issuecomment-2015087459

@rimolive @adriangonz @ramonpzg

juliusvonkohout avatar Apr 08 '24 05:04 juliusvonkohout

Who are the code owners for Seldon? Is there an ETA for that upgrade?

I don't think this is a blocker for KF 1.9 and Seldon is not part of the core components, but if they're willing to do that we can plan for a patch release in 1.9.

rimolive avatar Apr 15 '24 17:04 rimolive

The new code owners are described in https://github.com/kubeflow/manifests/pull/2532#issuecomment-2015087459

We can also write a synchronization script ourselves.

juliusvonkohout avatar Apr 16 '24 08:04 juliusvonkohout

Your call. As far as I know the manifest sync scripts are only for the core components, and since we need to write one for Model Registry (the team is about to send a PR for it) we can try write one for Seldon if, and only if, this won't take much time and effort. We have to set hard feature freeze date by Apr 22nd or the original schedule might be compromised.

rimolive avatar Apr 16 '24 16:04 rimolive

@lampajr can you tackle this and add a synchronization script as well?

juliusvonkohout avatar May 16 '24 10:05 juliusvonkohout

@lampajr can you tackle this and add a synchronization script as well?

Hi Julius, I gave it a quick try following https://github.com/kubeflow/manifests/blob/master/contrib/seldon/UPGRADE.md but it looks like the chart for the latest v1.18.1 release are not present in the helm chart repo https://storage.googleapis.com/seldon-charts

Do you know how can we get those charts there?

lampajr avatar May 16 '24 16:05 lampajr

@lampajr Maybe from here https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html#seldon-core-kustomize-install

juliusvonkohout avatar May 17 '24 11:05 juliusvonkohout

@lampajr Maybe from here https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html#seldon-core-kustomize-install

I think I can find a way directly cloning the seldon-core repo, will try this later today

lampajr avatar May 17 '24 13:05 lampajr