kubeflow
kserve/models-web-app v0.10.0 using kubeflow/kubeflow#2b4cc42e (not v1.7.0)
Description
In the readme of the manifest repository, the 1.7.0 Kubeflow release stated that the KServe Models Web App used is tag v0.10.0. But it is using a very old version of the kubeflow/kubeflow repository for using the components/crud-web-apps/common shared code.
As it is visible in kserve/models-web-app/v0.10.0/Dockerfile#L9, the commit used is 2b4cc42e, and has been committed the Nov 25, 2022 between the tag v1.6.1 (Oct 10, 2022) and v1.7.0-rc.0 (Feb 2, 2023)
This make the compilation of kserve/models-web-app not compatible with 1.7.0
Reproduce
git clone https://github.com/kserve/models-web-app
cd models-web-app
sed -i 's/2b4cc42e/tags\/v1.7.0/g' .\Dockerfile # replace 2b4cc42e with tags/v1.7.0
docker build -f Dockerfile .
Current state
The current master does not have a hardcoded commit in the Dockerfile but instead use a file containing the commit. See https://github.com/kserve/models-web-app/pull/65.
All of this is very confusing for maintaining versioning among app, especially when upgrading components. Synchronizing this new "COMMIT" file with tags would be a great way to keep consistency for components depending on code in the kubeflow/kubeflow repository.
Edit
Currently the master is checking out the kubeflow/kubeflow commit 046c6d3c8 (on Feb 13, 2023) so still not compatible with 1.7.0 commit (on March 29, 2023).
On the current master
kserve/models-web-app/frontend/COMMIT we have 3649e7e61 which has been merged on Mar 23 which is before release date 1.7.0 (Mar 29), so I guess yes the kserve is not up to date
@axel7083 then please provide a PR such that @kimwnasptd can review.
@kromanow94 can you investigate whether this is still relevant? We also need to update to kserve 0.11.2 anyway due to https://github.com/kubeflow/manifests/issues/2572 and https://github.com/kubeflow/manifests/issues/2553
https://github.com/kubeflow/manifests/issues/2603#issuecomment-1954059563
We probably need a new home for the web application https://kubeflow.slack.com/archives/C9V2WT2KV/p1709142634280649?thread_ts=1708948152.539709&cid=C9V2WT2KV
@kimwnasptd It seems you are the owner of https://github.com/kserve/models-web-app/ repo. Can you confirm that? We need to update and rebuild that image for Kubeflow 1.9 release.
@Ayush9026 are you still working on this, or do we need additional help?
