manifests
manifests copied to clipboard
Use hashFromEnv in dex component for static user passwords
Which issue is resolved by this Pull Request: Resolves #
Description of your changes:
Checklist:
- [ ] Unit tests pass:
Make sure you have installed kustomize == 3.2.1
-
make generate-changed-only
-
make test
-
@krishnadurai could you please review?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: krishnadurai, mvoitko
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~common/dex/OWNERS~~ [krishnadurai]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@krishnadurai @yanniszark Could you please add the lgtm label so I merge the PR?
Hi @mvoitko, can you please explain the purpose of this change.
@umka1332 The goal is to be a little bit more secure and not to store passwords in plain text in the source code. Also there was a comment
Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion
Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion
I'm sorry, I don't know how to do this. Could you please help with the link to the agenda and the meeting?
Yes of course. https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars here you can find all community meetings and join slack and the channel manifests-wg as well. In the calendar entry you can also find the meeting notes on google documents.
/lgtm
and the owner @krishnadurai approved
@kromanow94 you can also create a PR and I can approve :-) this here was approved by a probably stale owner @krishnadurai by accident then.