manifests icon indicating copy to clipboard operation
manifests copied to clipboard

Use hashFromEnv in dex component for static user passwords

Open mvoitko opened this issue 2 years ago • 5 comments

Which issue is resolved by this Pull Request: Resolves #

Description of your changes:

Checklist:

  • [ ] Unit tests pass: Make sure you have installed kustomize == 3.2.1
    1. make generate-changed-only
    2. make test

mvoitko avatar Jun 29 '22 11:06 mvoitko

@krishnadurai could you please review?

mvoitko avatar Jun 29 '22 11:06 mvoitko

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishnadurai, mvoitko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jul 25 '22 10:07 google-oss-prow[bot]

@krishnadurai @yanniszark Could you please add the lgtm label so I merge the PR?

mvoitko avatar Jul 26 '22 10:07 mvoitko

Hi @mvoitko, can you please explain the purpose of this change.

umka1332 avatar Aug 11 '22 15:08 umka1332

@umka1332 The goal is to be a little bit more secure and not to store passwords in plain text in the source code. Also there was a comment

mvoitko avatar Aug 14 '22 22:08 mvoitko

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

juliusvonkohout avatar Aug 25 '23 10:08 juliusvonkohout

Please put this on the agenda of the next manifest wg meeting in two weeks and join us for a discussion

I'm sorry, I don't know how to do this. Could you please help with the link to the agenda and the meeting?

mvoitko avatar Sep 01 '23 11:09 mvoitko

Yes of course. https://www.kubeflow.org/docs/about/community/#kubeflow-community-calendars here you can find all community meetings and join slack and the channel manifests-wg as well. In the calendar entry you can also find the meeting notes on google documents.

juliusvonkohout avatar Sep 04 '23 08:09 juliusvonkohout

/lgtm

and the owner @krishnadurai approved

juliusvonkohout avatar Dec 26 '23 20:12 juliusvonkohout

@kromanow94 you can also create a PR and I can approve :-) this here was approved by a probably stale owner @krishnadurai by accident then.

juliusvonkohout avatar Jan 02 '24 10:01 juliusvonkohout