manifests icon indicating copy to clipboard operation
manifests copied to clipboard

Clean up stale repo branches

Open PatrickXYS opened this issue 4 years ago • 6 comments

We should clean up kubeflow/manifests branches except for formal release branches, thus, I collected data points as below:

https://github.com/kubeflow/manifests/branches/all

Otherwise, it's weird to end-user that other branches exist alongside the release branches

Bobgy-patch-1
terrytangyuan-patch-1
zhenghuiwang-test-v1
automated-cherry-pick-of-#949-upstream-v1.0-branch
pdmack-patch-1
update_centraldashboard_
revert-323-feature/istio_update
zhenghuiwang-patch-1
richardsliu-patch-1
revert-134-admission-webhook
revert-109-notebookcrd1

/cc @kubeflow/wg-manifests-leads

PatrickXYS avatar Nov 25 '20 03:11 PatrickXYS

/priority p2

PatrickXYS avatar Nov 25 '20 05:11 PatrickXYS

Thanks @PatrickXYS driving this. I think you should have write access to this repo. Non of these branches are active, please help remove them

Jeffwan avatar Nov 25 '20 07:11 Jeffwan

Looks like I don't have access to delete protected branches

image

PatrickXYS avatar Nov 25 '20 16:11 PatrickXYS

@PatrickXYS Yeah, if some branches can not be deleted. I think it's fine for someone with permission to clean up later. Not a big deal

Jeffwan avatar Nov 25 '20 18:11 Jeffwan

I'd also like to give this effort a last push. Let's first try to get an explicit ACK from the creators of the branches, and then we can move forward and delete them.

I'm looking at the following branches right now https://github.com/kubeflow/manifests/branches/stale:

  • richardsliu-patch-1
  • zhenghuiwang-patch-1
  • update_centraldashboard_
  • pdmack-patch-1
  • zhenghuiwang-test-v1
  • terrytangyuan-patch-1

All of them are either closed or merged, so we should be OK deleting them. But let's also ask from a final ACK from their authors. If we don't have a response in something like a month, then I think we are OK removing them.

So @richardsliu @zhenghuiwang @kkasravi @terrytangyuan @pdmack are you OK with removing these stale branches? cc @zijianjoy

kimwnasptd avatar Feb 17 '22 19:02 kimwnasptd

Yes, please remove mine. I don't know why it's been made a protected branch.

terrytangyuan avatar Feb 17 '22 19:02 terrytangyuan

After review, I have removed the branch protection rules for the following branches:

richardsliu-patch-1
zhenghuiwang-patch-1
update_centraldashboard_
pdmack-patch-1
zhenghuiwang-test-v1
terrytangyuan-patch-1

Owners can now delete them as needed.

zijianjoy avatar Jan 12 '24 01:01 zijianjoy

Thank you very much. Cleaned and closed

/close

juliusvonkohout avatar Jan 12 '24 09:01 juliusvonkohout

@juliusvonkohout: Closing this issue.

In response to this:

Thank you very much. Cleaned and closed

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jan 12 '24 09:01 google-oss-prow[bot]