kubeflow
fix: reduce complexity of email regex in angular dashboard
fix for this https://huntr.com/bounties/0c1d6432-f385-4c54-beea-9f8c677def5b
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign orfeas-k for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![google-oss-prow[bot] avatar](https://avatars.githubusercontent.com/in/143327?v=4 "Published by a pub.dev verified publisher"){kind=small}
@CodeVigilanteOfficial I just want to note that the centraldashboard-angular rewrite is currently unreleased.
However, the normal dashboard uses the same email regex, so might also be susceptible.
In another PR we are planning to update it, but to a different regex, I would appreciate if you could take a look at it, and see if there are any performance concerns.
https://github.com/kubeflow/kubeflow/pull/7597
Also, did this PR accidentally change the line-endings of this file?
Because the GitHub diff is showing the full file as changed.
closing because https://github.com/kubeflow/kubeflow/pull/7597 was merged a while ago
/close
@thesuperzapper: Closed this PR.
In response to this:
closing because https://github.com/kubeflow/kubeflow/pull/7597 was merged a while ago
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.