kfp-tekton icon indicating copy to clipboard operation
kfp-tekton copied to clipboard

Update WML sample(s) to V4 GA

Open ckadner opened this issue 4 years ago • 6 comments

https://github.com/kubeflow/kfp-tekton/pull/650/checks?check_run_id=2960606837#step:3:288

samples/watson-train-serve/README.md:3: `[IBM Watson Machine Learning](https://www.ibm.com/cloud/machine-learning)` 404

... I think it's false alarm since the link from IBM really exists(redirected).

Fix the link (https://www.ibm.com/cloud/watson-studio) and check why the tools/python/verify_doc_links.py script does report it as 404 when it should follow the redirect (which it does when I run it locally)

Originally posted by @ckadner in https://github.com/kubeflow/kfp-tekton/issues/650#issuecomment-872436417

ckadner avatar Jul 01 '21 17:07 ckadner

@ckadner they added the redirect this morning, it was 404 yesterday after noon since they were doing some migration.

Tomcli avatar Jul 01 '21 17:07 Tomcli

the test should be passing now after triggering the github actions again

Tomcli avatar Jul 01 '21 17:07 Tomcli

@Tomcli -- the redirected link also makes clear that besides updating the link, we may also have to update some code as I see a few deprecation notices here:

https://pypi.org/project/watson-machine-learning-client-V4/

DEPRECATED!! This Watson Machine Learning client V4 Beta version is deprecated starting Sep 1st, 2020 and will be discontinued at the end of the migration period. Migrate to new V4 GA release of IBM Watson Machine Learning Python client. ... This package is being replaced in favor of new package ibm-watson-machine-learning in V4 GA release version of IBM Watson Machine Learning Python client.

https://ibm-wml-api-pyclient.mybluemix.net/

Important: The Watson Machine Learning Python client V3 and Watson Machine Learning Python client V4 Beta are deprecated since Sep 1st, 2020 on cloud and will be discontinued at the end of the migration period. Migrate to IBM Watson Machine Learning Client V4 GA packaged in the name of ibm-watson-machine-learning on cloud.

ckadner avatar Jul 01 '21 18:07 ckadner

@ScrapCodes has updated the WML link in PR #646 -- Thanks :-)

https://github.com/kubeflow/kfp-tekton/pull/646/files#diff-5593f07227ed6d1768749d08cfc16e9da277758d19244819b3582be31ba4063bR3

ckadner avatar Jul 01 '21 18:07 ckadner

thanks @ckadner, I think we need to update our WML example and services because we were using V4 beta. The V4 GA also includes all the autoAI stuff so the python code might also need to change.

Tomcli avatar Jul 01 '21 18:07 Tomcli

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 02 '22 08:03 stale[bot]

The WML deep learning service is deprecated. If needed we can create an autoAI example to replace it /close

Tomcli avatar Mar 28 '23 19:03 Tomcli

@Tomcli: Closing this issue.

In response to this:

The WML deep learning service is deprecated. If needed we can create an autoAI example to replace it /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Mar 28 '23 19:03 google-oss-prow[bot]