kfp-tekton icon indicating copy to clipboard operation
kfp-tekton copied to clipboard

Pipeline controller should not use the same namespace as tekton pipeline controller.

Open ScrapCodes opened this issue 1 year ago • 1 comments

/kind bug

What steps did you take and what happened: When I execute

kubectl delete -f https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.45.0/release.yaml

It ends up deleting the pipeline loop controller as well.

What did you expect to happen: If the two controller are on different namespaces, it might be easier to upgrade them.

Additional information: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Python Version (use python --version):
  • SDK Version:
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

ScrapCodes avatar Mar 02 '23 10:03 ScrapCodes

Personally I don't like to have too many namespaces. I think the right way is maybe expose namespace in the pipelineloop kustomize config so that users can configure them when they want to. And for the default namespace in the pipelineloop manifests, we can set the namespace to kubeflow if running it in tekton-pipelines is conflicting with the Tekton docs.

Tomcli avatar Mar 02 '23 23:03 Tomcli