kfp-tekton icon indicating copy to clipboard operation
kfp-tekton copied to clipboard

feat(sdk): add iterateParamPassStyle and itemPassStyle params to loop

Open Tomcli opened this issue 3 years ago • 5 comments

Which issue is resolved by this Pull Request: Resolves #1058

Description of your changes: Add new sdk support for new pipelineloop syntax. Two new fields iterateParamPassStyle and itemPassStyle, both of which can be either inline (default value) or file will sit on the same spec level as parallelism. The initial implementation is sdk support only.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

Tomcli avatar Oct 13 '22 19:10 Tomcli

cc @Udiknedormin

Tomcli avatar Oct 13 '22 19:10 Tomcli

cc @Udiknedormin

Tomcli avatar Oct 13 '22 19:10 Tomcli

/assign @yhwang

Tomcli avatar Oct 13 '22 19:10 Tomcli

/hold need some minor changes

Tomcli avatar Oct 14 '22 18:10 Tomcli

/unhold

Tomcli avatar Oct 20 '22 16:10 Tomcli

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, Udiknedormin, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 20 '22 16:10 google-oss-prow[bot]