kfctl icon indicating copy to clipboard operation
kfctl copied to clipboard

Ownerreferences no longer added to resources deployed through operator

Open HumairAK opened this issue 4 years ago • 2 comments

Hello, it seems this feature was initially added here but was later removed here in exchange for annotations. I also can't seem to find why this was changed. We found ownerreferences useful because we use ArgoCD to deploy our kfdefs and ArgoCD uses owner-references to draw out relationships (and possibly other logic) between the resources being deployed by the operator. Now Argocd only sees the kfdef and none of the components' resources being deployed. e.g.

image vs: image

Is this something that can be re-added?

HumairAK avatar Nov 24 '20 17:11 HumairAK

@animeshsingh @vpavlin

HumairAK avatar Nov 24 '20 17:11 HumairAK

I think the reason why it's been removed it is pretty much described in the PR (parent to the removal commit you linked, @HumairAK): https://github.com/kubeflow/kfctl/pull/411.

It all leads to this upstream kubernetes issue https://github.com/kubernetes/kubernetes/issues/65200 which will be fixed in kubernetes 1.20)

We use OCP, and I have no idea if the problem is actually present on our platform at all or not.

tumido avatar Nov 24 '20 20:11 tumido