kfctl icon indicating copy to clipboard operation
kfctl copied to clipboard

kfctl build not adding status.repoCache in kfdef file

Open mukul-shaunik-nokia opened this issue 4 years ago • 4 comments

While trying to deploy kubeflow kubeflow version - 1.1.0 kfctl version - 1.1.0 Expected Behaviour:

kfctl build -V -f <path to CONFIG file>

should add

status: reposCache: - localPath: '".cache/manifests/manifests"' name: manifests

to the CONFIG file.

Actual Behaviour

kfctl build -V -f <path to CONFIG file>

does not add

status: reposCache: - localPath: '".cache/manifests/manifests"' name: manifests

because of that whatever changes are done before running

kfctl apply -V -f <path to CONFIG file>

are overwritten as the existing .cache folder is deleted and new one is created.

mukul-shaunik-nokia avatar Nov 02 '20 22:11 mukul-shaunik-nokia

/cc @hemantha-kumara

mukul-shaunik-nokia avatar Nov 02 '20 22:11 mukul-shaunik-nokia

I think this is current expected behavior.

@Tomcli can you confirm?

moficodes avatar Nov 03 '20 20:11 moficodes

reposCache only appends in the apply command. I didn't own the build part so I'm not sure is this expected. But usually we shouldn't modify the .cache folder after kfctl build because all the changes should go to the generated kustomize folder.

Tomcli avatar Nov 03 '20 21:11 Tomcli

So I am also seeing this issue. I am using the cache folder to customize the notebook images that are available for my user's to select. I was able to force apply to not re-pull the cache by adding the repoCache lines to my config yaml file after running build but before apply.

SpontaneousDuck avatar Mar 10 '21 18:03 SpontaneousDuck