kfctl icon indicating copy to clipboard operation
kfctl copied to clipboard

Preserve comments in KFDef files (needed to for kpt)

Open jlewi opened this issue 5 years ago • 3 comments

Currently the kfctl code reads and writes the KFdef files. This serialization ends up stripping out any comments in the original KFDef files. This means we can't use kpt setters with KFDef files.

It looks like kpt is using this library for YAML parsing. https://github.com/kubernetes-sigs/kustomize/tree/master/kyaml/yaml

So its possible if we switched to using that library, kfctl could preserve comments.

jlewi avatar May 15 '20 21:05 jlewi

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.71
area/kfctl 0.97

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar May 15 '20 21:05 issue-label-bot[bot]

Looks like the kio library is the one that provides high level routines. https://github.com/kubernetes-sigs/kustomize/blob/master/kyaml/kio/doc.go

jlewi avatar May 18 '20 21:05 jlewi

I think google has already migrated to kpt instead, so this issue should be closed

PatrickXYS avatar Nov 25 '20 04:11 PatrickXYS