katib icon indicating copy to clipboard operation
katib copied to clipboard

fake-client in UTs

Open Garvit-77 opened this issue 8 months ago • 2 comments

What this PR does / why we need it: This PR implements Changes of UTs with fake client instead of gomock Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #2408

Checklist:

  • [Y] Docs included if any changes are user facing

Garvit-77 avatar Apr 09 '25 21:04 Garvit-77

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Apr 09 '25 21:04 google-oss-prow[bot]

Hey @tenzen-y Please let me know any changes and I think KatibClientMock does have the function for handling fake client should i create that with this pr ?

Garvit-77 avatar Apr 09 '25 21:04 Garvit-77

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 09 '25 00:07 github-actions[bot]

This pull request has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jul 29 '25 00:07 github-actions[bot]