katib icon indicating copy to clipboard operation
katib copied to clipboard

Replace `go mock` with `client-go fake client` in unit tests

Open vector-flow opened this issue 1 year ago • 23 comments

What you would like to be added?

go mock should be replaced with client-go fake client in unit tests.

Why is this needed?

Reference: https://github.com/kubeflow/katib/pull/2289#discussion_r1718769690

Love this feature?

Give it a 👍 We prioritize the features with most 👍

vector-flow avatar Aug 18 '24 05:08 vector-flow

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 16 '24 10:11 github-actions[bot]

/remove-lifecycle stale /good-first-issue /remove-label lifecycle/needs-triage /area testing

andreyvelich avatar Nov 16 '24 20:11 andreyvelich

@andreyvelich: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale /good-first-issue /remove-label lifecycle/needs-triage /area testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Nov 16 '24 20:11 google-oss-prow[bot]

Hi, can I take this up?

deveshidwivedi avatar Dec 21 '24 06:12 deveshidwivedi

Hi, can I take this up?

Feel free to take this one with /assign.

tenzen-y avatar Dec 23 '24 08:12 tenzen-y

/assign

deveshidwivedi avatar Dec 23 '24 12:12 deveshidwivedi

are you working on this @deveshidwivedi ?

chahatsagarmain avatar Jan 12 '25 13:01 chahatsagarmain

yes i am @chahatsagarmain

deveshidwivedi avatar Jan 12 '25 13:01 deveshidwivedi

hey @deveshidwivedi are you working on the issue ?

Garvit-77 avatar Feb 07 '25 11:02 Garvit-77

hi @Garvit-77 , i spent quite some time reading about it since its new for me, and i don't have the time to finish work on this right now. feel free to take it up!

deveshidwivedi avatar Feb 08 '25 04:02 deveshidwivedi

/unassign

deveshidwivedi avatar Feb 08 '25 04:02 deveshidwivedi

/assign

Garvit-77 avatar Feb 08 '25 14:02 Garvit-77

/assign

SriTanyaG avatar Feb 11 '25 06:02 SriTanyaG

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 12 '25 10:05 github-actions[bot]

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

github-actions[bot] avatar Jun 01 '25 15:06 github-actions[bot]

/reopen

tenzen-y avatar Jun 02 '25 07:06 tenzen-y

@tenzen-y: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Jun 02 '25 07:06 google-oss-prow[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 31 '25 15:08 github-actions[bot]

/remove-lifecycle stale

andreyvelich avatar Sep 01 '25 12:09 andreyvelich

@andreyvelich is it okay for me to take up this issue? can't see no attached PRs for this one

shivangshandilya avatar Oct 18 '25 02:10 shivangshandilya

Sure, thanks @shivangshandilya! /assign @shivangshandilya

andreyvelich avatar Oct 18 '25 06:10 andreyvelich

/assign

adity1raut avatar Nov 05 '25 04:11 adity1raut

hey @adity1raut it would have been appreciated if if you had checked with me first whether I was working on it before raising a PR. but now that you have done so please don't close it. Regards

shivangshandilya avatar Nov 06 '25 07:11 shivangshandilya