Replace `go mock` with `client-go fake client` in unit tests
What you would like to be added?
go mock should be replaced with client-go fake client in unit tests.
Why is this needed?
Reference: https://github.com/kubeflow/katib/pull/2289#discussion_r1718769690
Love this feature?
Give it a 👍 We prioritize the features with most 👍
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/remove-lifecycle stale /good-first-issue /remove-label lifecycle/needs-triage /area testing
@andreyvelich: This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.
In response to this:
/remove-lifecycle stale /good-first-issue /remove-label lifecycle/needs-triage /area testing
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hi, can I take this up?
Hi, can I take this up?
Feel free to take this one with /assign.
/assign
are you working on this @deveshidwivedi ?
yes i am @chahatsagarmain
hey @deveshidwivedi are you working on the issue ?
hi @Garvit-77 , i spent quite some time reading about it since its new for me, and i don't have the time to finish work on this right now. feel free to take it up!
/unassign
/assign
/assign
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.
/reopen
@tenzen-y: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
/remove-lifecycle stale
@andreyvelich is it okay for me to take up this issue? can't see no attached PRs for this one
Sure, thanks @shivangshandilya! /assign @shivangshandilya
/assign
hey @adity1raut it would have been appreciated if if you had checked with me first whether I was working on it before raising a PR. but now that you have done so please don't close it. Regards