katib icon indicating copy to clipboard operation
katib copied to clipboard

Replaced hpcloud with nxadm for tail package in Go

Open vector-flow opened this issue 1 year ago • 1 comments

What this PR does / why we need it: This issue helps to migrate the dependency of the tail package in katib from https://github.com/hpcloud/tail to https://github.com/nxadm/tail. This change is required because hpcloud has not been maintaining their implementation of the tail package.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes https://github.com/kubeflow/katib/issues/2299

Checklist:

  • [ ] Docs included if any changes are user facing

vector-flow avatar Jul 03 '24 18:07 vector-flow

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jul 10 '24 00:07 google-oss-prow[bot]