katib icon indicating copy to clipboard operation
katib copied to clipboard

Make test fields private in Go unit tests

Open tariq-hasan opened this issue 10 months ago • 2 comments

What this PR does / why we need it:

Following the suggestion to keep the test fields private within Go unit tests, this PR implements the necessary changes.

The unit tests for Go have been run and validated in this CI Workflow.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

  • [ ] Docs included if any changes are user facing

tariq-hasan avatar Apr 25 '24 23:04 tariq-hasan

I wonder if we should re-run Unit Test 1.27.1 given that this issue was flagged before in other PRs and jobs were restarted.

Other jobs look to be okay.

I was also wondering if a dedicated issue needs to be opened to look into this.

tariq-hasan avatar Apr 26 '24 00:04 tariq-hasan

I wonder if we should re-run Unit Test 1.27.1 given that this issue was flagged before in other PRs and jobs were restarted.

Other jobs look to be okay.

I was also wondering if a dedicated issue needs to be opened to look into this.

@tariq-hasan I tried to re-run 5 times, but that case never succeeded in CI... In your local, what happened?

tenzen-y avatar Apr 30 '24 14:04 tenzen-y

I wonder if we should re-run Unit Test 1.27.1 given that this issue was flagged before in other PRs and jobs were restarted. Other jobs look to be okay. I was also wondering if a dedicated issue needs to be opened to look into this.

@tariq-hasan I tried to re-run 5 times, but that case never succeeded in CI... In your local, what happened?

After I restarted it 6 times, that case succeeded. That case is so flaky...

tenzen-y avatar Apr 30 '24 14:04 tenzen-y

I was also wondering if a dedicated issue needs to be opened to look into this.

Actually, we already have a dedicated issue: https://github.com/kubeflow/katib/issues/2269

tenzen-y avatar Apr 30 '24 14:04 tenzen-y

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tariq-hasan, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Apr 30 '24 14:04 google-oss-prow[bot]