katib icon indicating copy to clipboard operation
katib copied to clipboard

Updated dockerfiles for grpc installation for ppc64le

Open aditijadhav38 opened this issue 1 year ago • 5 comments

This PR targets to get the katib/suggestions built on PowerPC. This PR is continuation of PR https://github.com/kubeflow/katib/pull/2262

aditijadhav38 avatar Mar 19 '24 07:03 aditijadhav38

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aditijadhav38 Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Mar 19 '24 07:03 google-oss-prow[bot]

@tenzen-y Could you please review the changes..

aditijadhav38 avatar Mar 28 '24 10:03 aditijadhav38

updated dockerfiles for grpc builds for powerPC compilation~ #2262

I'm still wondering if we should not support ppc64le based on this discussion: https://github.com/kubeflow/katib/pull/2262#pullrequestreview-1934843268

Anyway, we should resolve that discussion before we move this forward.

tenzen-y avatar Mar 28 '24 15:03 tenzen-y

updated dockerfiles for grpc builds for powerPC compilation~ #2262

I'm still wondering if we should not support ppc64le based on this discussion: #2262 (review)

Anyway, we should resolve that discussion before we move this forward.

For this, a comment has been already added https://github.com/kubeflow/katib/pull/2262#issuecomment-1998212429. Please check. Could you please add comment in that discussion if you have any more queries.

aditijadhav38 avatar Mar 29 '24 05:03 aditijadhav38

@tenzen-y please refer to https://github.com/kubeflow/katib/pull/2262#issuecomment-1998212429 - does that help? As mentioned, we are happy to help maintaining, especially if anything architecture-specific comes up...

lehrig avatar Apr 17 '24 14:04 lehrig