Implement validations for darts suggestion service
What this PR does / why we need it:
I implemented validations for the darts suggestion service.
Also, I commonized a function to validate NAS operations as pkg/suggestion/v1beta1/nas/common/validate.py.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1126
Checklist:
- [ ] Docs included if any changes are user facing
Coverage decreased (-0.09%) to 72.857% when pulling d338dd292d982e38ba333f0239d6f3b7c802d9bb on tenzen-y:implement-darts-validation-algorithm into 478e01d612c0d1c05c7fceea29edbea922b30b9e on kubeflow:master.
@anencore94
Could you sign CLA with [email protected]?
https://github.com/kubeflow/katib/pull/1926/checks?check_run_id=7882927727
@anencore94 Could you sign CLA with
[email protected]?https://github.com/kubeflow/katib/pull/1926/checks?check_run_id=7882927727
Thaks, I was signed in with different email, but now I signed with both email :)
Looks good ! /lgtm
/hold until corrections are complete.
Please take another look since I addressed all your review comments. @anencore94
/hold cancel
Thanks @tenzen-y
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: anencore94, johnugeorge, tenzen-y
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [johnugeorge]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment