katib icon indicating copy to clipboard operation
katib copied to clipboard

[chore] Upgrade Go version to v1.18

Open tenzen-y opened this issue 3 years ago • 3 comments

What this PR does / why we need it: I upgraded Go version to v1.18.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

  • [ ] Docs included if any changes are user facing

tenzen-y avatar Aug 12 '22 01:08 tenzen-y

Coverage Status

Coverage remained the same at 72.857% when pulling 8fd3613a52d89276697cc5efd64899f5d153cdf3 on tenzen-y:upgrade-go-version into 8d58b0a53e35bdea7c1442dc0500a7e3cfa05ad3 on kubeflow:master.

coveralls avatar Aug 12 '22 01:08 coveralls

Thanks for updates :)

/lgtm

anencore94 avatar Aug 12 '22 04:08 anencore94

Thanks /approve

johnugeorge avatar Aug 17 '22 04:08 johnugeorge

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Aug 17 '22 04:08 google-oss-prow[bot]

/lgtm

johnugeorge avatar Aug 17 '22 04:08 johnugeorge