katib Chore: Uses Istio v1beta1 api

There is nothing different between v1alpha3 and v1beta1 currently IMO. But it's better to use v1beta1 for the Istio upgrade in the future.

Mar 03 '22 13:03 haoxins

Hi @haoxins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mar 03 '22 13:03 aws-kf-ci-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoxins To complete the pull request process, please assign andreyvelich after the PR has been reviewed. You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Mar 03 '22 13:03 google-oss-prow[bot]

Coverage decreased (-0.1%) to 74.138% when pulling 64e584144c7e0d5f2a602be3da34ce3e1bbd18c6 on haoxins:chore-istio-v1beta1 into 0515c1ecf3c5ac92bd4bf070a39d82ac604277ec on kubeflow:master.

Mar 03 '22 14:03 coveralls

/lgtm

Mar 07 '22 15:03 tenzen-y

we should hold this PR for a while. The manifests folder is synced to upstream Kubeflow/manifests for every release. Hence, it is better to match Istio version for other components as well.

https://github.com/kubeflow/manifests/tree/master/apps/katib/upstream

/hold

Mar 08 '22 13:03 johnugeorge

we should hold this PR for a while. The manifests folder is synced to upstream Kubeflow/manifests for every release. Hence, it is better to match Istio version for other components as well.

https://github.com/kubeflow/manifests/tree/master/apps/katib/upstream

/hold

Agreed, I will work on upgrade the Istio manifests into 1.13+ at first.

Mar 09 '22 03:03 haoxins

@kubeflow/wg-automl-leads Which will be used, networking.istio.io/v1alpha3 or networking.istio.io/v1beta1 for VirtualService in the next major release of kubeflow?

If we use networking.istio.io/v1beta1, we need to merge this PR.

Jun 07 '22 16:06 tenzen-y