katib icon indicating copy to clipboard operation
katib copied to clipboard

Draft: Support log-uniform scale in search space definition

Open fabianvdW opened this issue 4 years ago • 8 comments
trafficstars

Hello everyone,

I would like to see some movement in #1207. I started by adding the distribution field everywhere I could find and already modifying the behaviour in the suggestion package at relevant places.

I am guessing this PR is not even close to finished. Maybe someone can point out to me which parts are still missing(and or have to be adapated), or discuss if my approach to fixing #1207 is good. Perhaps one of the main contributors can also take over from here. What this PR does / why we need it: This adds a field distribution to SearchSpace which allows for the "log-uniform" scale (and possibly other scales) to be supported for sampling from parameter search spaces.

Fixes #1207

Checklist:

  • [ ] Docs included if any changes are user facing

fabianvdW avatar Oct 08 '21 10:10 fabianvdW

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabianvdW To complete the pull request process, please assign andreyvelich after the PR has been reviewed. You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot avatar Oct 08 '21 10:10 google-oss-robot

Hi @fabianvdW. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aws-kf-ci-bot avatar Oct 08 '21 10:10 aws-kf-ci-bot

Hi @fabianvdW, Are you still working on this PR ? If you don't mind I'd like to add some more features based on this PR.

anencore94 avatar Jan 20 '22 08:01 anencore94

Hi @fabianvdW, Are you still working on this PR ? If you don't mind I'd like to add some more features based on this PR.

Not currently working on this. I don't have enough insight to finish this on my own.

fabianvdW avatar Jan 24 '22 18:01 fabianvdW

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 27 '22 16:04 stale[bot]

/ok-to-test

johnugeorge avatar Apr 27 '22 16:04 johnugeorge

@fabianvdW: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 3f500a2df2abcddb023ba1b861d611dd475d3209 link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aws-kf-ci-bot avatar Apr 27 '22 17:04 aws-kf-ci-bot

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 21 '22 07:09 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 13 '23 05:09 github-actions[bot]