katib icon indicating copy to clipboard operation
katib copied to clipboard

[UI Feature] Expose the underlying Suggestion

Open andreyvelich opened this issue 4 years ago • 6 comments

/kind feature

The new Katib UI should show the YAML for the Experiment's Suggestion.

One solution can be:

  1. Rename YAML tab to Experiment YAML
  2. Add new tab Suggestion YAML and show Suggestion info there.

Later we can add another tab to monitor Suggestion logs. Add Suggestion Conditions under Experiment Conditions in the Overview tab.

andreyvelich avatar Feb 18 '21 21:02 andreyvelich

/cc @kimwnasptd

andreyvelich avatar Feb 18 '21 21:02 andreyvelich

@andreyvelich let's rename this issue to [UI Feature] Expose the underlying Suggestion or something similar, since we will be discussing our approach of how to show the underlying Suggestion CR in many different places.

Add Suggestion Conditions under Experiment Conditions in the Overview tab.

This grouping makes sense. The UI effort is non-trivial, but we will need to slightly extend the backend to expose the owned Suggestion CR

Later we can add another tab to monitor Suggestion logs.

Agree, although we will need to also extend the backend to export these logs

The new Katib UI should show the YAML for the Experiment's Suggestion. One solution can be:

  1. Rename YAML tab to Experiment YAML
  2. Add new tab Suggestion YAML and show Suggestion info there.

I think I'd prefer to keep the YAML tab and have a switching mechanism underneath, like some radio buttons (?). I'd like to create some iterations with both cases so we can see how they look and then decide on which road to follow.

kimwnasptd avatar Feb 19 '21 13:02 kimwnasptd

but we will need to slightly extend the backend to expose the owned Suggestion CR

I believe the backend already has fetch_suggestion API which returns Suggestion CR: https://github.com/kubeflow/katib/blob/master/pkg/ui/v1beta1/backend.go#L326.

Agree, although we will need to also extend the backend to export these logs

That's right. Currently, we haven't decided how to receive Suggestion and Trials log from the backend.

I think I'd prefer to keep the YAML tab and have a switching mechanism underneath, like some radio buttons (?). I'd like to create some iterations with both cases so we can see how they look and then decide on which road to follow.

I was thinking about the same way with radio buttons and one YAML tab. This approach decreases number of tabs and simplify UX.

Does it look good if we have separate tab for the Suggestion log or you have any other better places to implement it?

andreyvelich avatar Feb 19 '21 23:02 andreyvelich

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 11 '21 01:06 stale[bot]

/lifecycle frozen

andreyvelich avatar Jun 11 '21 14:06 andreyvelich

/priority p3

andreyvelich avatar Feb 11 '22 18:02 andreyvelich