Unused code, possible loss of push parameter

[shikha130vv]

/kind bug

In https://github.com/kubeflow/fairing/blob/master/fairing/builders/cluster/gcs_context.py, function def generate_pod_spec(self, image_name, push): args = ["--dockerfile=Dockerfile", "--destination=" + image_name, "--context=" + self.uploaded_context_url] if not push: args.append("--no-push") return client.V1PodSpec( containers=[client.V1Container( name='kaniko', image='gcr.io/kaniko-project/executor:v0.7.0', args=["--dockerfile=Dockerfile", "--destination=" + image_name, "--context=" + self.uploaded_context_url], )], restart_policy='Never' ) Here args is being defined but not used. And the V1PodSpec for Kaniko container is not making any use of push parameter.

[issue-label-bot[bot]]

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.95. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[jinchihe]

@shikha130vv Thanks for you raise the problem. We are going to introduce the pytest in #300 to check the related issues.

[jtfogarty]

/priority p2 /area engprod