fairing icon indicating copy to clipboard operation
fairing copied to clipboard

Don't cache docker image layers during post-commit test

Open karthikv2k opened this issue 5 years ago • 3 comments

Currently we cache docker image layers from previous builds. This causes a condition where a fresh install using requirements.txt can have very different behavior compared to cached version. Yesterday, fresh install of Fairing was failing on my local system but not on the remote builds. The reason was that a new version of urllib3 was released that introduced version incompatibility during pip install. This was not caught in our remote builds because the of cached version of pip install layer in our test image (requirements.txt didn't change so cache was valid).

We should only cache pip packages (~/.cache/pip) across builds and not the layers of the test image.

karthikv2k avatar Apr 23 '19 18:04 karthikv2k

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.62. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Apr 23 '19 18:04 issue-label-bot[bot]

There is an rsynch based solution as per this article. https://medium.com/@scythargon/cache-for-python-pip-downloads-and-wheels-in-docker-67f24e7cd84e What do you say?

shikha130vv avatar Aug 06 '19 09:08 shikha130vv

/area engprod /priority p2

jtfogarty avatar Jan 15 '20 23:01 jtfogarty