community icon indicating copy to clipboard operation
community copied to clipboard

Make the permission model for triagers more scalable; Eliminate need for write access

Open jlewi opened this issue 5 years ago • 4 comments
trafficstars

Adding more people to the issue triage rotation is blocked on the fact that issue triagers need fairly expansive permissions in order to triage issues.

Right now issue triagers need Write permission in order to be able to tag issues into projects; see https://github.com/kubeflow/community/issues/250#issuecomment-528123182

It turned out the Issue Triage GitHub Role was insufficient.

Letting the number of individuals with write access across all repos continue to grow doesn't seem viable.

How can we make the permissions more fine grained?

Looking at our triage process we have started to distinguish between two roles

  1. Global triagers - assign kind and area labels
  2. Area owners who assign priority and scheduling (Kanban boards).

For global triage, the Issue Triage GitHub Role should be sufficient to attach labels for kind and area.

We would still need a way for area owners to assign issues to projects. Possible options

  • The prow /project plugin see https://github.com/kubeflow/community/issues/250
  • Create a GitHub Action to add issues to projects based on labels
    • e.g. add label project/kfctl-1.0 to add it to project kfctl 1.0
    • This has the advantage of letting us control permissions through the issue triage role.
  • File a feature request with GitHub to add ability to add issues to projects to the triage Role
    • I created Ticket ID: 511337

In the short term perhaps we should create a new GitHub group issue-triagers and give that group just the triage role across all repositories.

jlewi avatar Jan 03 '20 00:01 jlewi

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.96. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jan 03 '20 00:01 issue-label-bot[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 03 '20 05:05 stale[bot]

Issue-Label Bot is automatically applying the labels:

Label Probability
area/engprod 0.86

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar May 10 '20 06:05 issue-label-bot[bot]

/lifecycle frozen

jlewi avatar May 20 '20 20:05 jlewi