common icon indicating copy to clipboard operation
common copied to clipboard

Allow modification of controller's replica index/type labels

Open terrytangyuan opened this issue 4 years ago • 5 comments

Per comment in https://github.com/kubeflow/tf-operator/pull/1171#discussion_r439856038, given that each operator may have different labels, we should discuss whether we want to allow each operator's controller that implements JobController to change ReplicaIndexLabel and ReplicaTypeLabel. For example, something like the following for tf-operator:

func (jc *JobController) GetReplicaTypeLabelKey() string {
	return tfReplicaTypeLabel
}

cc @gaocegege @Jeffwan @ChanYiLin @johnugeorge

terrytangyuan avatar Jun 17 '20 14:06 terrytangyuan

Issue-Label Bot is automatically applying the labels:

Label Probability
area/operator 0.92
kind/feature 0.73

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Jun 17 '20 14:06 issue-label-bot[bot]

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.73

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

kf-label-bot-dev[bot] avatar Jun 17 '20 14:06 kf-label-bot-dev[bot]

I think we can have an interface there, and leave replica-type as default implementation in kubeflow/common, different operators can still override it if there's a need.

Jeffwan avatar Jun 22 '20 17:06 Jeffwan

Yes they should be able to override the defaults.

terrytangyuan avatar Jun 22 '20 17:06 terrytangyuan

I will take the issue /assign @ChanYiLin

ChanYiLin avatar Jan 14 '21 08:01 ChanYiLin