common icon indicating copy to clipboard operation
common copied to clipboard

Add MaxConcurrentReconciles to JobControllerConfiguration

Open Syulin7 opened this issue 2 years ago • 5 comments

add MaxConcurrentReconciles to JobControllerConfiguration

fixes: https://github.com/kubeflow/training-operator/pull/1707#discussion_r1057075176

Syulin7 avatar Jan 15 '23 07:01 Syulin7

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval by writing /assign @terrytangyuan in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Jan 15 '23 07:01 google-oss-prow[bot]

@johnugeorge PTAL, I will do this in training operator once this is merged.

Syulin7 avatar Jan 15 '23 08:01 Syulin7

@johnugeorge I update license, please approve running workflows, thanks.

Syulin7 avatar Jan 16 '23 07:01 Syulin7

We can wait till https://github.com/kubeflow/training-operator/issues/1714 is completed. This will make it easy to make common changes

johnugeorge avatar Jan 17 '23 19:01 johnugeorge

ok, I agree.

Syulin7 avatar Jan 18 '23 08:01 Syulin7