common icon indicating copy to clipboard operation
common copied to clipboard

Use Interface instead of lister/informer in controller

Open Jeffwan opened this issue 4 years ago • 3 comments

A follow up PR of https://github.com/kubeflow/common/pull/155

In the common code base, we still use low level listers and hasSynced which is not used in training-operator any more. Let's change to XXInterface from kubeClientSet. Otherwise, we have to create sharedInformers and then create listers which is unnecessary in latest client pattern

Jeffwan avatar Aug 30 '21 05:08 Jeffwan

Good idea. May I assign this feature to myself?

zw0610 avatar Aug 30 '21 07:08 zw0610

/assign @zw0610

Jeffwan avatar Aug 30 '21 18:08 Jeffwan

@zw0610 sure. Feel free to pick it up

Jeffwan avatar Aug 30 '21 18:08 Jeffwan