code-intelligence icon indicating copy to clipboard operation
code-intelligence copied to clipboard

Put Docker image for the GitHub triage action in the kubeflow docker hub registry

Open jlewi opened this issue 5 years ago • 6 comments
trafficstars

The GitHub action for Kubeflow triage is currently using the image hamelsmu/kubeflow-triage

https://github.com/kubeflow/code-intelligence/blob/9fceba0c7141ab8e02b0f049ee696194cdf24eb4/.github/workflows/build_image.yaml#L15

https://github.com/kubeflow/code-intelligence/blob/9fceba0c7141ab8e02b0f049ee696194cdf24eb4/Issue_Triage/action/action.yml#L20

We should instead push the image to Docker in the kubeflow organization and then update the image to use that.

Note GitHub actions doesn't currently support GCR.

jlewi avatar Nov 26 '19 00:11 jlewi

Issue-Label Bot is automatically applying the label kind/feature to this issue, with a confidence of 0.83. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Nov 26 '19 00:11 issue-label-bot[bot]

We have the kubeflow github organization https://hub.docker.com/orgs/kubeflow

We have the kubeflowrobot account for automating pushes to kubeflow

I created a personal access token for this account. This is currently stored in google's internal secret management system; Google team can access it.

I replaced the DOCKER_USERNAME and DOCKER_PASSWORD secrets on kubeflow/code-intelligence with kubeflowrobot and the associated access token.

jlewi avatar Nov 26 '19 01:11 jlewi

When the action triggered we got a permission error trying to push to DockerHub https://github.com/kubeflow/code-intelligence/commit/ea1e5995d7e9bc8e6326c1adf9c5149af2294ced/checks?check_suite_id=329459221

jlewi avatar Nov 26 '19 18:11 jlewi

I'm going to try reproducing it locally; by logging in as the kubeflow robot to docker and building the image.

I got the same error.

jlewi avatar Nov 26 '19 18:11 jlewi

It looks like I had to do a couple things

  1. In Docker hub I had to create the repository kubeflow/kubeflow-triage
  2. I had to add the developer team with read/write permissions on that repository

I was then able to successfully run docker push using the kubeflowrobot account

jlewi avatar Nov 26 '19 19:11 jlewi

https://hub.docker.com/repository/docker/kubeflow/kubeflow-triage

jlewi avatar Nov 26 '19 19:11 jlewi