code-intelligence icon indicating copy to clipboard operation
code-intelligence copied to clipboard

issue_triage.py should not consider labels that have been removed

Open jlewi opened this issue 5 years ago • 3 comments

Right now if a label is added and then removed issue_triage.py would still take into account that label when deciding whether an issue needs triage.

This is because we look at the time labels were created: https://github.com/kubeflow/code-intelligence/blob/ecbab8b8ca38ce8175c0a2550ab2a916e14d0e1d/py/issue_triage/triage.py#L81

But we don't take into account whether that label is still present on the issue.

jlewi avatar Nov 25 '19 22:11 jlewi

Issue-Label Bot is automatically applying the label kind/bug to this issue, with a confidence of 0.77. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

issue-label-bot[bot] avatar Nov 25 '19 22:11 issue-label-bot[bot]

/area engprod /priority p2

jtfogarty avatar Jan 16 '20 17:01 jtfogarty

Could I work on this issue? I'm planning to contribute to Kubeflow during GSoC '20. Could you please also add me to the slack channel?

mukul-mehta avatar Mar 18 '20 23:03 mukul-mehta