code-intelligence
code-intelligence copied to clipboard
kubeflow
[Model Sync] Needs Sync Needs to take into account open PR
Right now needs sync only compares the latest model to the model on master.
As a result, we end up firing off a Tekton pipeline if there is a PR open with a pending update. We should detect that and not fire off a pipeline.
Issue-Label Bot is automatically applying the labels:
| Label | Probability |
|---|---|
| kind/bug | 0.53 |
Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.
![issue-label-bot[bot] avatar](https://avatars.githubusercontent.com/in/27079?v=4 "Published by a pub.dev verified publisher"){kind=small}
@hamelsmu Do you know offhand if there is a good way to encode metadata in a PR?
I didn't see anything in the payload. https://developer.github.com/v4/object/pullrequest/
I think we will just have to put data into the title and comment and use that to look for PRs.
@jlewi I am not 100% sure what you are looking for. Can you describe it in a bit more detail?
@hamelsmu I'd like to be able to programmatically identify if the bot had previously opened a PR to update a model to a specific version. So the easiest thing would be if it was easy to annotate the PR with some machine readable metadata; i.e. a json object containing whatever metadata the bot needs.
It looks like the only way to encode information on a PR would be in the comment itself but maybe I'm missing something.