blog icon indicating copy to clipboard operation
blog copied to clipboard

add dependabot config script

Open davidspek opened this issue 4 years ago • 8 comments

Inspired by https://github.com/kubeflow/pipelines/issues/4682 I created a script that will create a config file for depandabot so that it knows what directories to scan. It will scan the repository for files named *ockerfile*, package*.json, *requirements.txt, go.* and Gemfile*. It is setup for dockerfiles, npm packages, pip, ruby and gomod dependencies at the moment. It is trivial to further customize what folders are selected if further customization is needed. It also parses the closest OWNERS file for a given dependency listing file, and assigns the relevant approvers and adds the relevant reviewers to the PRs it creates.

This is a sibling PR to https://github.com/kubeflow/pipelines/pull/5015, https://github.com/kubeflow/kubeflow/pull/5542, https://github.com/kubeflow/kfserving/pull/1309, https://github.com/kubeflow/arena/pull/403, https://github.com/kubeflow/testing/pull/855, https://github.com/kubeflow/fairing/pull/550, https://github.com/kubeflow/kfp-tekton/pull/432, https://github.com/kubeflow/katib/pull/1420, https://github.com/kubeflow/tf-operator/pull/1224, https://github.com/kubeflow/kfp-tekton-backend/pull/28, https://github.com/kubeflow/mpi-operator/pull/319, https://github.com/kubeflow/pytorch-operator/pull/315, https://github.com/kubeflow/metadata/pull/255, https://github.com/kubeflow/xgboost-operator/pull/107, https://github.com/kubeflow/fate-operator/pull/26, https://github.com/kubeflow/mxnet-operator/pull/87, https://github.com/kubeflow/website/pull/2459, https://github.com/kubeflow/kfctl/pull/479, https://github.com/kubeflow/examples/pull/843, https://github.com/kubeflow/code-intelligence/pull/198, https://github.com/kubeflow/gcp-blueprints/pull/192 and https://github.com/kubeflow/common/pull/107.

As it stands now, there will be about 11 PRs that will be created with this configuration.

For reference, the PRs that will be created can be found here: https://github.com/DavidSpek/blog/pulls

davidspek avatar Jan 25 '21 14:01 davidspek

/assign kramachandran

davidspek avatar Jan 25 '21 15:01 davidspek

@DavidSpek: GitHub didn't allow me to assign the following users: kramachandran.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

/assign kramachandran

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 25 '21 15:01 k8s-ci-robot

/assign @terrytangyuan

davidspek avatar Jan 25 '21 15:01 davidspek

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidSpek, terrytangyuan To complete the pull request process, please assign after the PR has been reviewed. You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 25 '21 15:01 k8s-ci-robot

@terrytangyuan I wasn't able to assign the owner of the repo @kramachandran as he isn't a member of Kubeflow. Who should be assigned to approve this?

davidspek avatar Jan 25 '21 15:01 davidspek

I am holding the PR to have some control over when it gets merged so that the optional test infra doesn't get overloaded if all the repo's were to merge this at the same time. /hold

davidspek avatar Jan 26 '21 23:01 davidspek

I think we don't need this for kubeflow/blog, do we?

Bobgy avatar Apr 06 '21 08:04 Bobgy

@Bobgy does look like there are things that need to be kept up to date. https://github.com/DavidSpek/blog/pulls

davidspek avatar Apr 06 '21 08:04 davidspek