arena icon indicating copy to clipboard operation
arena copied to clipboard

Fix: #966, correct cleanPolicy position

Open panpan0000 opened this issue 1 year ago • 6 comments

panpan0000 avatar Dec 18 '23 06:12 panpan0000

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt[bot] avatar Dec 18 '23 06:12 cr-gpt[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 18 '23 06:12 google-cla[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: panpan0000 Once this PR has been reviewed and has the lgtm label, please assign cheyang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Dec 18 '23 06:12 google-oss-prow[bot]

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt[bot] avatar Dec 18 '23 06:12 cr-gpt[bot]

Thank you for your PR, but it's a breaking change that will prevent installations of the older version of arena from being upgraded to the latest version.

Syulin7 avatar Dec 18 '23 07:12 Syulin7

let's discuss in the thread of original issue

Thank you @Syulin7 , but people's intuitions are "arena will be the CLI tool to manage the jobs , after installing kubeflow and its training-operator" But the current arena will never submit any job for up to date kubeflow standard training-operator and CRDs. So every new user will be blocked here and has to give up arena. I'm afraid that's not the good way out for community.

May I suggest that : (1) create a maintenance branch to support those OLD users with old kubeflow CRD, especially for those users in AliYun. with NOTES in README to tell the max compatbile kubeflow version, to avoid confusion . (2) the main branch just supports latest kubeflow CRD, and add a NOTE in README, to tell people the minimal kubeflow version for this branch.

panpan0000 avatar Dec 18 '23 08:12 panpan0000