gitops-template icon indicating copy to clipboard operation
gitops-template copied to clipboard

fix: vultr installation

Open Seven45 opened this issue 1 year ago • 4 comments

Description

bump kubernetes_version from v1.28.2+1 to v1.28.9+1

Related Issue(s)

Fixes https://github.com/kubefirst/kubefirst/issues/2261

How to test

Seven45 avatar Aug 10 '24 12:08 Seven45

@Seven45 Thanks for the PR, I'll test it today and get back to you.

fharper avatar Aug 12 '24 12:08 fharper

FYI, @jokestax is fixing something else for Vultr that need to be fixed before we can test this PR. Once it's done, he will also test this one.

fharper avatar Aug 12 '24 19:08 fharper

His PR was merged, so I'll be able to test this one.

fharper avatar Aug 14 '24 17:08 fharper

I'll need to give it another try tomorrow. I had an issue that isn't related to this PR.

fharper avatar Aug 14 '24 20:08 fharper

@fharper @Seven45 the issue is fixed in #794

jokestax avatar Aug 22 '24 08:08 jokestax

@jokestax: let us know when it's merged so we can test this PR again. Sorry for the delay @Seven45

fharper avatar Aug 22 '24 12:08 fharper

@fharper that pr solves the issue,i have upgraded it to 1.30,so you can test that branch itself:)

jokestax avatar Aug 22 '24 12:08 jokestax

@Seven45 so sorry but someone else on the team updated the Kubernetes version by fixing another issue, which mean this PR has now no changes, or would have been a version lower than what we decided to use.

I'm so sorry, would have love to merge your commit as a contributor. With that said, thanks a lot for this PR as it helped us find that Vultr wasn't working anymore. We are implementing better daily testing to ensure this does not happen anymore.

Even if I need to close this PR, I consider you a contributor, and would love to send you some swag as a token of our appreciation. Can you ping me on our Slack community (I'm @Fred) or by email at [email protected].

fharper avatar Aug 22 '24 20:08 fharper