website icon indicating copy to clipboard operation
website copied to clipboard

update "runtime" docs in zh version

Open SherlockShemol opened this issue 2 years ago • 11 comments

  • Please check if the PR fulfills these requirements
  • [ ] Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

docs update

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

SherlockShemol avatar Jan 04 '24 11:01 SherlockShemol

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dingyin after the PR has been reviewed. You can assign the PR to them by writing /assign @dingyin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot avatar Jan 04 '24 11:01 kubeedge-bot

It looks like the DCO signature is still unresolved. You need to execute git rebase HEAD~6 --signoff on your local branch, then git log check the commit record to see if all your commits are signed. After adding them all, then execute the git push --force-with-lease origin master command, which should solve the problem.

wbc6080 avatar Jan 04 '24 11:01 wbc6080

It looks like the DCO signature is still unresolved. You need to execute git rebase HEAD~6 --signoff on your local branch, then git log check the commit record to see if all your commits are signed. After adding them all, then execute the git push --force-with-lease origin master command, which should solve the problem.

yes I have followed the instruction and signiture does appears in my git log.But DCO just doesn't pass.sorry for my unskilled pr.give me some time and I will figure out.

SherlockShemol avatar Jan 04 '24 11:01 SherlockShemol

It looks like the DCO signature is still unresolved. You need to execute git rebase HEAD~6 --signoff on your local branch, then git log check the commit record to see if all your commits are signed. After adding them all, then execute the git push --force-with-lease origin master command, which should solve the problem.看起来 DCO 签名问题仍未解决。您需要在本地分支上执行 git rebase HEAD~6 --signoff ,然后 git log 检查提交记录,看看是否所有提交都已签名。全部添加完毕后,再执行 git push --force-with-lease origin master 命令,问题应该就解决了。

Finally I found out the problem.sorry for so many ugly commit.

SherlockShemol avatar Jan 04 '24 11:01 SherlockShemol

You can use git reset to merge these commits into one. The following steps are for your reference.

  • git reset bfc529d045f0407e770972489ede033ebcc1fa37 (Remember do not use git reset --hard )
  • git add *
  • git commit --amend -s
  • git push -f origin master

Shelley-BaoYue avatar Jan 04 '24 11:01 Shelley-BaoYue

You can use git reset to merge these commits into one. The following steps are for your reference.

* git reset [bfc529d](https://github.com/kubeedge/website/commit/bfc529d045f0407e770972489ede033ebcc1fa37)  (Remember do not use git reset --hard )

* git add *

* git commit --amend -s

* git push -f origin master

Thanks and it works! Time to learn more git command.

SherlockShemol avatar Jan 04 '24 11:01 SherlockShemol

I found that some pictures have been updated in this PR, but I don’t quite understand what has been updated. Could you please describe it?

yes it's weird.I have done nothing to those images.I fork and clone the repo and go directly to modify the "runtime" file.But those images is shown to be modified. Maybe it's because of mode of the files.

SherlockShemol avatar Jan 04 '24 12:01 SherlockShemol

I found that some pictures have been updated in this PR, but I don’t quite understand what has been updated. Could you please describe it?

yes it's weird.I have done nothing to those images.I fork and clone the repo and go directly to modify the "runtime" file.But those images is shown to be modified. Maybe it's because of mode of the files.

How about do not select these image files when git add?

Shelley-BaoYue avatar Jan 04 '24 12:01 Shelley-BaoYue

I found that some pictures have been updated in this PR, but I don’t quite understand what has been updated. Could you please describe it?

yes it's weird.I have done nothing to those images.I fork and clone the repo and go directly to modify the "runtime" file.But those images is shown to be modified. Maybe it's because of mode of the files.

How about do not select these image files when git add?

yes, give me some time.

SherlockShemol avatar Jan 04 '24 13:01 SherlockShemol

I found that some pictures have been updated in this PR, but I don’t quite understand what has been updated. Could you please describe it?

yes it's weird.I have done nothing to those images.I fork and clone the repo and go directly to modify the "runtime" file.But those images is shown to be modified. Maybe it's because of mode of the files.

How about do not select these image files when git add?

Done.Thank you.

SherlockShemol avatar Jan 04 '24 14:01 SherlockShemol

@SherlockShemol: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubeedge-bot avatar Feb 01 '24 02:02 kubeedge-bot