sedna
sedna copied to clipboard
EntGAN: A Distributed GAN Framework Baed on Multi-task
/kind feature Fixes #336
Welcome @nailtu30! It looks like this is your first PR to kubeedge/sedna 🎉
/ping @MooreZheng
hi @nailtu30 ,you should remove the unnecessary system files, such as .DS_Store
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign sids-b after the PR has been reviewed.
You can assign the PR to them by writing /assign @sids-b
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
The current proposal of GAN itself is fine as a algorithm, e.g., for lifelong learning. But a distributed GAN as a standalone scheme for Sedna like edge-cloud joint inference requires notrivial workloads on the module design.
My suggestion is to make the proposal as two phases. Phase One focuses on pure algorithm GAN on lifelong learning using Ianvs. Phase Two focuses on intergating GAN into Sedna.
Lack integration solution to Ianvs. In my opinion, the proposed GAN framework should be embeded into the training phase of Ianvs.
The proposal is overall good but
- need to be polished to strengthen the motivation
- make the scenario clear instead of a framework without any supporting dataset examples