kubeedge icon indicating copy to clipboard operation
kubeedge copied to clipboard

Unit tests for `cloud/pkg/cloudhub/common/helper.go`

Open 1Shubham7 opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind test

What this PR does / why we need it:

I have added unit tests for cloud/pkg/cloudhub/common/helper.go

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

1Shubham7 avatar Jun 24 '24 12:06 1Shubham7

Don't know why some checks are failing for the same tests I had before.

1Shubham7 avatar Jun 24 '24 22:06 1Shubham7

/lgtm

WillardHu avatar Jul 02 '24 01:07 WillardHu

/approve

WillardHu avatar Jul 16 '24 07:07 WillardHu

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WillardHu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot avatar Jul 16 '24 07:07 kubeedge-bot