kubeedge icon indicating copy to clipboard operation
kubeedge copied to clipboard

an implementation of DMI: device and mapper management

Open RyanZhaoXB opened this issue 2 years ago • 2 comments

What type of PR is this? /kind feature

What this PR does / why we need it: we have proposed the Device Management Interface in https://github.com/kubeedge/kubeedge/issues/3760. now we are implementing the interface in edgecore. thus the mapper can connect to edgecore through DMI to management device.

Which issue(s) this PR fixes:

Fixes #3760

Special notes for your reviewer:

Does this PR introduce a user-facing change?: no. this pr will not change the user-facing interface. the change is about the interface which the developer of mappers will use. the API of DMI is proposed in https://github.com/kubeedge/kubeedge/pull/3915


RyanZhaoXB avatar Jul 06 '22 01:07 RyanZhaoXB

we are testing this pr and will reorganize the commits later.

RyanZhaoXB avatar Jul 06 '22 01:07 RyanZhaoXB

@gy95 @fisherxu please help to review this pr. thanks!

RyanZhaoXB avatar Aug 11 '22 01:08 RyanZhaoXB

please add copyright header for every new added file

wackxu avatar Aug 12 '22 09:08 wackxu

Can you split the pr into two part, one pr is the proto interface definition and automatically generated code and vendor, the other pr is the interface implementation and related logic code modification, The proto interface definition is important, so we can review the proto interface definition first, also it is also convenient to review

wackxu avatar Aug 17 '22 07:08 wackxu

Can you split the pr into two part, one pr is the proto interface definition and automatically generated code and vendor, the other pr is the interface implementation and related logic code modification, The proto interface definition is important, so we can review the proto interface definition first, also it is also convenient to review

it is a good idea. i have proposed a pr https://github.com/kubeedge/kubeedge/pull/3915 for the proto interface definition before but it is a little old. i will re-proposed it.

RyanZhaoXB avatar Aug 17 '22 07:08 RyanZhaoXB

please add copyright header for every new added file

i have added the copyright header.

RyanZhaoXB avatar Aug 18 '22 13:08 RyanZhaoXB

all the review comments have been modified. while it should be merged only after this pr(https://github.com/kubeedge/kubeedge/pull/4119) is merged.

RyanZhaoXB avatar Sep 15 '22 13:09 RyanZhaoXB

all the review comments have been modified. please help me to re-check this pr. thanks.

RyanZhaoXB avatar Sep 15 '22 13:09 RyanZhaoXB

the mapper of DMI is proposed in this pr(https://github.com/kubeedge/mappers-go/pull/78). this mapper is developed for modbus.

RyanZhaoXB avatar Sep 16 '22 02:09 RyanZhaoXB

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed. You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

kubeedge-bot avatar Sep 19 '22 11:09 kubeedge-bot